[PATCH] D26413: [XRay] Support AArch64 in compiler-rt

[Renato Golin via llvm-commits]

rengolin added inline comments.


================
Comment at: lib/xray/xray_interface.cc:29
 
+static const int16_t cSledLength =
 #if defined(__x86_64__)
----------------
I'd rather have the repetition here. This is looking odd... :)


================
Comment at: lib/xray/xray_trampoline_AArch64.S:32
+    /* Handler address is nullptr if handler is not set */
+    CMP X2, #0
+    BEQ FunctionEntry_restore
----------------
can't you compare the address before saving and restoring all those registers?


https://reviews.llvm.org/D26413