[PATCH] D26474: Parse resolations only once

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 19:30:58 PST 2016

On 10 November 2016 at 15:43, Rui Ueyama <ruiu at google.com> wrote:
> All I have to do is to just leave "Differential revision" line in a commit
> message, then the "git svn commit" automatically updates and closes the
> corresponding phab patch for me. I don't know how it works, I probably
> didn't set it up, so it's the out of the box behavior for me. I honestly
> don't care at  all whether my Phab patches are left open or not, but since
> it's easy to close, I didn't find it that annoying. What's the problem with
> Phab? Is it fixable? Phab is useful for me to review, so please don't stop
> using it.

The problem is that it is yet another tool with lots of clicks to get
a patch up.

If it is just a place for me to put a patch in a way you like reading,
that is fine. If I must put up with the "right way" of using it I will
just not use it. Since you don't care if it stays open and since it is
you, and not Eugene reviewing the patches, I will just keep doing what
I am doing and ignore Eugene.

BTW, when sending me patches using phabricator is not in any way an
improvement. Part of the reason I like post commit review is that it
makes working with just email easier.


More information about the llvm-commits mailing list