[PATCH] D26514: Get rid of DWARFFormValue::getFixedFormSizes(uint8_t AddrSize, uint16_t Version).

Greg Clayton via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 14:26:04 PST 2016


clayborg abandoned this revision.
clayborg added a comment.

Looking as some of the comments made me think if a nicer way to fix some of the redundant code in DWARFFormValue.cpp and also clear up some of the questions that Adrian had about the fixed sized forms having the assertion in skipVariableLengthValue() in the cases where the fixed sized forms were happening. I am going to abandon this revision and open another otherwise all of the inlined comments won't make sense since a lot will have changed, but for the better.


https://reviews.llvm.org/D26514





More information about the llvm-commits mailing list