[PATCH] D26438: [Verifier] Add verification for TBAA metadata

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

>>> We've had the auto upgrade logic for what looks like approximately 3 years.  I think it is reasonable to deprecate the functionality and eventually remove it, though I know (from off-list emails) that it will break (in terms of performance, not correctness) downstream users.
>> 
>> Can you explain more on why it will break downstream users in terms of performance?
> 
> I meant if we go by Mehdi's strategy of dropping old style tbaa metadata instead of auto-upgrading them then downstream users who generate the old style tbaa metadata will no longer get the benefit of TBAA.  Their code will be correctly compiled, but will run slower.

Right, we can does not mean we should. I'd only do it if it simplifies your work and clean-up code. If it is well contained and isolated let's just keep it.


https://reviews.llvm.org/D26438