[PATCH] D21739: [TLI] Add functions determining if int parameters/returns should be zeroext/signext.

Wed Nov 9 20:46:18 PST 2016

koriakin added a comment.

In https://reviews.llvm.org/D21739#587028, @davidxl wrote:

> Is related TLI change upstreamed?

In https://reviews.llvm.org/D21739#589870, @hfinkel wrote:

> In https://reviews.llvm.org/D21739#589647, @davidxl wrote:
>
> > This seems fine. Hal, do you have other concerns?
>
>
> Generally, I think this is the right approach. Do we only have a use case for i32, or would it apply to i16, i8, i1 too? If we only have a use case for i32 right now, I'm fine with leaving generalization to when we have use cases for other types.

As far as I'm aware, only i32 need this treatment - i8 and i16 corresponding to C types are always signext/zeroext due to C standard working that way, and i64 tend to fill the whole register.

> Is the diff now missing something? I don't see anything here that would cause a functional change, but there's a test case which implies otherwise.

The test was supposed to be attached to https://reviews.llvm.org/D21736, not this diff - fixed now.

Repository:
  rL LLVM

https://reviews.llvm.org/D21739