[PATCH] D26155: Enable Loop Sink pass for functions that has profile.

[David Li via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp:650
 
+  MPM.add(createLoopSinkPass());
+  // Get rid of LCSSA nodes.
----------------
mzolotukhin wrote:
> Can't we schedule this right after LICM?
> I think we're placing LoopSinking in a separate instance of loop pass manager - is that what we want?
LICM also serves as an IR canonicalization pass that enables other optimization, so loopSinking needs to be a very late IR pass to avoid undoing LICM result too early. Otherwise the logic of loopSinking can be baked into LICM as proposed originally.


Repository:
  rL LLVM

https://reviews.llvm.org/D26155