[PATCH] D26473: [asan/win] Delay load dbghelp.dll to delay ucrtbase.dll initialization

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 9 15:31:47 PST 2016


rnk added a comment.

In https://reviews.llvm.org/D26473#591156, @kubabrecka wrote:

> I don't think adding those huge binary files into the repository is a good idea.  Can the test use the DLLs from a system location?


No, my system copy of dbghelp is not new enough to reproduce the issue. All tests fail reliably on systems with a new enough version of dbghelp. I can delete the test if you think 1MB of data is too much cost to pay for this, but we open ourselves up to regressions, as the bots probably don't have "new" dbghelp.


https://reviews.llvm.org/D26473





More information about the llvm-commits mailing list