[llvm] r286171 - [AMDGPU] Allow hoisting of comparisons out of a loop and eliminate condition copies

[Mekhanoshin, Stanislav via llvm-commits]

I cannot see the problem with the code generated. In fact it is now 2 instructions less and seems to be equivalent to the old one on behavior.
What does this test check? Presence of a missing instruction, exact match of the produced ISA?

Stas

-----Original Message-----
From: Michel Dänzer [mailto:michel at daenzer.net] 
Sent: 8 ноября 2016 г. 22:48
To: Mekhanoshin, Stanislav <Stanislav.Mekhanoshin at amd.com>
Cc: llvm-commits at lists.llvm.org
Subject: Re: [llvm] r286171 - [AMDGPU] Allow hoisting of comparisons out of a loop and eliminate condition copies


Hi Stanislav,


On 08/11/16 08:04 AM, Stanislav Mekhanoshin via llvm-commits wrote:
> Author: rampitec
> Date: Mon Nov  7 17:04:50 2016
> New Revision: 286171
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=286171&view=rev
> Log:
> [AMDGPU] Allow hoisting of comparisons out of a loop and eliminate 
> condition copies

This change broke the piglit test
spec at glsl-1.30@execution at fs-discard-exit-2 for me with the radeonsi driver on Kaveri. I'm attaching shader dumps for the good and bad case.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer