[PATCH] D22696: [CodeGenPrep] Skip merging empty case blocks

Jun Bum Lim via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 9 12:31:17 PST 2016


junbuml marked an inline comment as done.
junbuml added inline comments.


================
Comment at: test/CodeGen/X86/ragreedy-hoist-spill.ll:183
+  ; CHECK: movq %r{{.*}}, {{[0-9]+}}(%rsp)
+  ; CHECK: land.rhs485
   %cmp476 = icmp eq i8 undef, 0
----------------
manmanren wrote:
> The whole purpose of this testing case is to make sure that a spill is not hoisted to a hotter outer loop.
> 
> As long as that is still true with your change, it is fine.
Thanks Manman.
Yes, this change should not change such behavior. In this test, the spill is  hoisted in  sw.bb474, which is not the hotter outer loop;  still even colder than  the inner loop.


https://reviews.llvm.org/D22696





More information about the llvm-commits mailing list