[PATCH] D26256: [InstCombine] Don't set debug location when folding through a phi node

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 9 10:14:06 PST 2016


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks fairly reasonable to me.

The changes seem independent though, so if you're inclined - you could split it up into one change and one test per commit for easier isolation/archaeology/etc.

(presumably we could do the simple thing of "if they're actually the same location, keep it" - so in a build with discriminators we wouldn't keep it (because they'd have distinct discriminators) but otherwise/in a normal debug build we could keep them)


https://reviews.llvm.org/D26256





More information about the llvm-commits mailing list