[PATCH] D26177: [tsan] Add support for C++ exceptions into TSan (call __tsan_func_exit during unwinding)

[Dmitry Vyukov via llvm-commits]

dvyukov added a comment.

In https://reviews.llvm.org/D26177#590243, @kubabrecka wrote:

> In https://reviews.llvm.org/D26177#590185, @dvyukov wrote:
>
> > 1. Please add tsan pass flag that turns exception interception off. We may need to disable it during deployment if it causes instability, compilation errors or too large binary increase.
>
>
> Will do.  What's "too large" for you?  This does cause increases, which are larger in -O0 builds.


Any increase will cause some failures. We should have -fno-exceptions for most binaries, but maybe not for all.

>> 2. Are we sure that longjmp won't cause double call to __tsan_func_exit? At least MSVC longjmp will unwind stack and call destructors, which will most likely lead to double exit calls. Linux docs are vague in this regard. Not sure about mac.
> 
> I'll try to check.  Besides longjmp, do you have some particular scenario that's worth adding a testcase for?

Can't think of anything else.


https://reviews.llvm.org/D26177