[PATCH] D26177: [tsan] Add support for C++ exceptions into TSan (call __tsan_func_exit during unwinding)

[Dmitry Vyukov via llvm-commits]

dvyukov added a comment.

1. Please add tsan pass flag that turns exception interception off. We may need to disable it during deployment if it causes instability, compilation errors or too large binary increase.

2. Are we sure that longjmp won't cause double call to __tsan_func_exit? At least MSVC longjmp will unwind stack and call destructors, which will most likely lead to double exit calls. Linux docs are vague in this regard. Not sure about mac.



================
Comment at: projects/compiler-rt/test/tsan/exceptions.cc:111
+  throws_and_catches();
+  fprintf(stderr, (shadow_stack_size == __tsan_testonly_shadow_stack_current_size() ? "OK.\n" : "Shadow stack leak!\n"));
+
----------------
More than 80 columns. Please fix.


https://reviews.llvm.org/D26177