[PATCH] D25975: AMDGPU/SI: Make f16 a legal type for VI subtargets

[Konstantin Zhuravlyov via llvm-commits]

kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:3602
 
-  if (VT != MVT::f32 && VT != MVT::f64)
+  if (VT != MVT::f16 && VT != MVT::f32 && VT != MVT::f64)
     return SDValue();
----------------
arsenm wrote:
> Does this need an f16 is legal check? If not this can probably just be an !isVector check, any of the other FP types are unusable 
This is needed for v_cmp_class_f16. I have forgotten to add Subtarget->has16BitInsts(), which I have added in the revised patch.


https://reviews.llvm.org/D25975