[PATCH] D26384: IR, Bitcode: Change bitcode reader to no longer own its memory buffer.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 20:51:18 PST 2016


mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/IR/Module.h:164
+  OwnedMemoryBuffer;              ///< Memory buffer directly owned by this
+                                  ///< module, for legacy clients only.
   std::unique_ptr<GVMaterializer>
----------------
What other legacy clients do we have? Is it only the C API? The C API can be handled differently: it can have its own wrapper struct around the `Module` class, and this wrapper would own the buffer.


https://reviews.llvm.org/D26384





More information about the llvm-commits mailing list