[PATCH] D26289: [CMake] Fix llvm_setup_rpath function

Azharuddin Mohammed via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 12:58:00 PST 2016


azharudd added a comment.

In https://reviews.llvm.org/D26289#588354, @beanz wrote:

> I think there is actually a more general solution to this. At the top of the function we can just have:
>
>   if(CMAKE_INSTALL_RPATH)
>     return()
>   endif()
>
>
> Then we can remove the conditionals on CMAKE_INSTALL_RPATH, and just allow the target to inherit from the global setting, which is the default.


sounds good. updated.


https://reviews.llvm.org/D26289





More information about the llvm-commits mailing list