[PATCH] D26128: [X86][AVX512] Removing llvm x86 intrinsics for _mm_mask_move_{ss|sd} intrinsics.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 6 23:01:35 PST 2016


craig.topper added a comment.

Two minor comments. But LGTM otherwise.



================
Comment at: lib/IR/AutoUpgrade.cpp:341
          Name == "avx2.vbroadcasti128" ||
+         Name.startswith("avx512.mask.move.ss") ||
+         Name.startswith("avx512.mask.move.sd") ||
----------------
This is the whole name of the intrinsic so startswith is unnecessary. You should be able to combine both checks to a single Name.startswith("avx512.mask.move.s").


https://reviews.llvm.org/D26128





More information about the llvm-commits mailing list