[PATCH] D24607: [mips] seq macro support

[Vasileios Kalintiris via llvm-commits]

vkalintiris accepted this revision.
vkalintiris added a comment.

LGTM but there's a wrong constant that you should change before committing this.



================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:3977
+
+    if (Imm > -8000 && Imm < 0) {
+      Imm = -Imm;
----------------
We want the -0x8000 constant literal here.


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:4316-4320
+         
+       .Case("a1", 5)
+           
+     .Case("a2", 6)
            .Case("a3", 7)
----------------
Can you fix the identation here?


https://reviews.llvm.org/D24607