[PATCH] D26241: [ELF] Speed-up lld up to 5 times by replacing llvm:regex with simple string matcher.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 06:24:38 PDT 2016


grimar added a comment.

I wonder if that really passes all the tests ?
My concern comes from https://reviews.llvm.org/D23803?vs=on&id=68992&whitespace=ignore-most#toc which was initially posted to implement
[char].
That patch later was converted to use regexps instead of initial implementation. Though implementation in your patch seems does not handle [char]. Don't our tests should catch that ?


Repository:
  rL LLVM

https://reviews.llvm.org/D26241





More information about the llvm-commits mailing list