[PATCH] D26130: [ELF] - Implemented --symbol-ordering-file option.

[George Rimar via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/SymbolListFile.cpp:65
+namespace {
+class SymbolOrderingListParser final : public ScriptParserBase {
+public:
----------------
rafael wrote:
> It is not entirely clear you want the ScriptParser infrastructure. For example, do we have to handle quotes?
> 
> I would probably make this format dead simple. One symbol per line, symbols with newlines are not supported.
> 
I expected this file can have comments like --sections--list-file.
Not sure that more parsing code here is better than reusing ScriptParser. I did that though.


================
Comment at: test/ELF/symbol-ordering-file.s:9
+# BEFORE:      Contents of section .text:
+# BEFORE-NEXT:  11000 11223344 55
+
----------------
rafael wrote:
> Changing .text to .foo should make this easier to read as .foo doesn't have an implicit alignment.
linker does not concatinate .foo into single section like .text.* :( 
So I had to use .text


https://reviews.llvm.org/D26130