[PATCH] D24338: [InlineCost] Remove CallPenalty and change MinSizeThreshold to 5

[Xinliang David Li via llvm-commits]

On Tue, Nov 1, 2016 at 5:52 PM, Mehdi AMINI <mehdi.amini at apple.com> wrote:

> mehdi_amini added a comment.
>
> In https://reviews.llvm.org/D24338#585295, @eraman wrote:
>
> > I agree that having a call penalty in addition to argument set up cost
> skews inline cost computation.
>
>
> What about register spills for instance? An IR call can really be more
> costly when lowered to machine code.
>

Do you mean parameter passing? That should be counted independently  by the
instruction visitor.

David

>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D24338
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161101/571fce2b/attachment.html>