[PATCH] D25482: [PPC] Allow two post RA schedulers to be in the pipeline and select one depending on the Machine Function's subtarget

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 18:28:51 PDT 2016


MatzeB added a comment.

In https://reviews.llvm.org/D25482#585479, @amehsan wrote:

> > 
> > 
> >> 2- targetSchedulesPostRAScheduling
> > 
> > This seems redundant to me as soon as 1) is implemented.
>
> Maybe I am missing something, but this seems different from (1). Note that addPostRASched is called from addMachinePasses which is not typically overriden by targets. SystemZ has a usecase for targetSchedulesPostRAScheduling which cannot be covered by (1).


Overriding addPostRASched() with an empty function has the same effect as returning true in targetSchedulesPostRAScheduling(), hasn't it?


https://reviews.llvm.org/D25482





More information about the llvm-commits mailing list