[PATCH] D26212: IRMover: Avoid accidentally mapping types from the destination module (PR30799)

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 14:43:22 PDT 2016


mehdi_amini added inline comments.


================
Comment at: test/LTO/X86/type-mapping-bug.ll:3
+; RUN: llvm-as -o %t.src.bc %S/Inputs/type-mapping-src.ll
+; RUN: llvm-lto %t.dst.bc %t.src.bc -o=/dev/null
+
----------------
pcc wrote:
> Would it be possible to write this test with `llvm-link` instead of `llvm-lto`?
Likely not. I fixed a similar issues in r280599 / D23841 and it requires the LLVMContext to be initialized with ODR type uniquing, which only happens in LTO. (We may be able to add an option to llvm-link, but we can't really test it as it is supposed to be "NFC").


https://reviews.llvm.org/D26212





More information about the llvm-commits mailing list