[PATCH] D26043: Replace GAlloc with a template function.

[Rafael Espíndola via llvm-commits]

I see. I will fix that.

Cheers,
Rafael


On 1 November 2016 at 13:12, Rui Ueyama <ruiu at google.com> wrote:
> One test is failing with this patch because of the reason I described in the
> review thread for https://reviews.llvm.org/D25516.
>
> On Tue, Nov 1, 2016 at 5:09 AM, Rafael Espíndola
> <rafael.espindola at gmail.com> wrote:
>>
>> Ping on the commit :-)
>>
>> Cheers,
>> Rafael
>>
>>
>> On 28 October 2016 at 18:22, Rui Ueyama <ruiu at google.com> wrote:
>> > ruiu added inline comments.
>> >
>> >
>> > ================
>> > Comment at: ELF/Memory.cpp:23
>> > +
>> > +void elf::freeArena() {
>> > +  for (SpecificAllocBase *Alloc : SpecificAllocBase::Instances)
>> > ----------------
>> > rafael wrote:
>> >> Do we still need to free this at a specific point in time? If not just
>> >> letting the destructors take care of it should simplify the code.
>> > This is for the use case in which you directly call lld::elf::link from
>> > your program. In that use case, we want to free all memories before
>> > returning from link().
>> >
>> >
>> > https://reviews.llvm.org/D26043
>> >
>> >
>> >
>
>