[PATCH] D25482: [PPC] Allow two post RA schedulers to be in the pipeline and select one depending on the Machine Function's subtarget

Ehsan Amiri via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 11:18:44 PDT 2016


amehsan updated this revision to Diff 76605.
amehsan added a comment.

Eric, asked for a little more clean up.

I am aware of the following mechanisms for scheduling post ra schedulers.

1- The new virtual function in this patch
2- targetSchedulesPostRAScheduling
3- enablePostRA method in the subtarget
4- PostRAScheduler flag in include/llvm/Target/TargetSchedule.td
5- command line option to turn on new scheduler instead of old one.
6- command line option to turn off post ra schedulers
7- SubstitutePass to use new scheduler instead of old one.

Each of these seems to have a slightly different usecase. If there is a likelihood that we can remove some of these, it might be worthwhile to open a PR. otherwise we can leave it as is.

Matt: Sorry I just realized I could have applied your comment to this update.  I will make sure to check those before committing though.


https://reviews.llvm.org/D25482

Files:
  include/llvm/CodeGen/Passes.h
  include/llvm/CodeGen/TargetPassConfig.h
  lib/CodeGen/MachineScheduler.cpp
  lib/CodeGen/PostRASchedulerList.cpp
  lib/CodeGen/TargetPassConfig.cpp
  lib/Target/PowerPC/PPCTargetMachine.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25482.76605.patch
Type: text/x-patch
Size: 14076 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161101/e21b8830/attachment.bin>


More information about the llvm-commits mailing list