[PATCH] D25667: Fix call sites with spurious .c_str() calls from explicit StringRef conversion (NFC)

Malcolm Parsons via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 10:48:04 PDT 2016


On 1 November 2016 at 17:27, Mehdi Amini <mehdi.amini at apple.com> wrote:
> But I think you’ll have to change it: IIUC it catches string -> string conversion only
> (i.e. this likely won’t catch conversion to StringRef, or conversion from other than std::string).

readability-redundant-string-cstr handles string -> StringRef and
string -> Twine.
It doesn't yet support conversions from SmallString.

-- 
Malcolm Parsons


More information about the llvm-commits mailing list