[PATCH] D26106: RegisterCoalescer: Ignore interferences for constant physregs

[Quentin Colombet via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM.

Nitpicks below.



================
Comment at: include/llvm/CodeGen/MachineRegisterInfo.h:555
+  /// function. Reading from a constant register always results in the same
+  /// value regardless of any definitions or the position inside the function.
   bool isConstantPhysReg(unsigned PhysReg) const;
----------------
Isn't that implied by "constant"?


================
Comment at: test/CodeGen/AArch64/regcoal-constreg.mir:6
+---
+# CHECK: name: func
+# CHECK-NOT: COPY
----------------
Could you add a comment explaining what this function is testing?


Repository:
  rL LLVM

https://reviews.llvm.org/D26106