[lld] r285608 - Move IsAbsolute from SymbolAssignment to Expr.

[Rui Ueyama via llvm-commits]

On Mon, Oct 31, 2016 at 1:00 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 31 October 2016 at 15:07, Rui Ueyama <ruiu at google.com> wrote:
> > On Mon, Oct 31, 2016 at 11:28 AM, Rafael Espíndola
> > <rafael.espindola at gmail.com> wrote:
> >>
> >> On 31 October 2016 at 13:55, Rui Ueyama <ruiu at google.com> wrote:
> >> > Isn't this almost the same as the Eugene's patch?
> >>
> >> Which one? The patches I have seen were trying to ignore a relative
> >> relocation to an absolute symbol. This is trying to fix which symbols
> >> are or are not absolute.
> >
> >
> > https://reviews.llvm.org/D25441
>
> I am truly sorry, yes, it has a similarity with it.
>

It is part of my mistake because I tried to come up with a different
approach which resulted in holding off the patch. I'm sorry, Eugene. Ping
me if you haven't heard of me for a few days.


> I started looking at this area because of
> https://llvm.org/bugs/show_bug.cgi?id=30406 and didn't noticed the
> overlap. Hopefully it shouldn't be hard to add the extra fields to
> "struct Expr" if needed.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161031/67d7f691/attachment.html>