[PATCH] D26092: Implement vector shift builtins - clang portion.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 31 12:52:17 PDT 2016


echristo added inline comments.


================
Comment at: lib/Headers/altivec.h:7702
+
+static __inline__ vector signed short __ATTRS_o_ai vec_sldw(
+    vector signed short __a, vector signed short __b, unsigned const int __c) {
----------------
kbarton wrote:
> This is a minor nit, but I seem to remember definitions in this file being orderd by size: char, short, int, long, long long.
> Can you please move these definitions up, to between the char and int, for consistency?
Might want to make sure and clang format everything.


https://reviews.llvm.org/D26092





More information about the llvm-commits mailing list