[PATCH] D26152: [ARM][MC] Cleanup ARM Target Assembly Parser

[Renato Golin via llvm-commits]

rengolin added inline comments.


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:9233
   StringRef IDVal = DirectiveID.getIdentifier();
   if (IDVal == ".word")
+    parseLiteralValues(4, DirectiveID.getLoc());
----------------
This looks like a string switch case.


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:9280
   else if (IDVal == ".thumb_set")
-    return parseDirectiveThumbSet(DirectiveID.getLoc());
-
-  if (!IsMachO && !IsCOFF) {
+    parseDirectiveThumbSet(DirectiveID.getLoc());
+  else if (!IsMachO && !IsCOFF) {
----------------
Why no return here, too?


https://reviews.llvm.org/D26152