[PATCH] D26123: Fix SegFault in Expected

Yichao Yu via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 29 17:12:18 PDT 2016


yuyichao added a comment.

And I think it didn't cause any problem because `Error` and `unique_ptr` has the same layout except for the lowest bit. Before https://reviews.llvm.org/rL285426, the lowest bit should never be set when the `Expected` is checked/assertion is disabled but this is not true anymore for an unchecked `Expected` on a release build after the change.


https://reviews.llvm.org/D26123





More information about the llvm-commits mailing list