[PATCH] D25966: [AArch64] Lower multiplication by a constant int to shl+add+shl

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 29 09:03:38 PDT 2016

rengolin added a comment.

In https://reviews.llvm.org/D25966#582890, @haicheng wrote:

> The biggest motivation is that GCC can do this, but LLVM cannot.  My patch is conservative and it does not make big change to the performance.  I have not observed any noticeable regression, but the gain is small.  spec2006/h264ref and spec2006/povray have around 1% improvement.  One internal benchmark which is integer multiplication centric has much larger improvement.

Any regressions? Not that I'm expecting any, but... :)

I'll come back a bit later once I've done a proper review.




More information about the llvm-commits mailing list