[PATCH] D26100: Bitcode: Maintain block info block abbreviations in the BitstreamCursor.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 16:38:47 PDT 2016

mehdi_amini added a comment.

I think this is basically like "merging" responsibility from the bitstream reader and the cursor into the cursor. The cursor isn't just a "position" in the stream with the "bitstreamreader" in charge of keeping the "context".
If this is correct, I'm not against it but at least you should reflect it in the class documentation.

Also added Duncan for an extra opinion here.


More information about the llvm-commits mailing list