[PATCH] D25849: [GVN] Prevent load coercion with irregular vector types

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 16:03:41 PDT 2016

davide added inline comments.

Comment at: lib/Transforms/Scalar/GVN.cpp:783
          "CanCoerceMustAliasedValueToLoad fail");
   // Convert source pointers to integers, which can be manipulated.
davide wrote:
> reames wrote:
> > Have you looked at what's required to fix this code path?  This should be the only logic protected by the predicate you're modifying.
> No, I didn't. Personally I looked at this because I got an internal report of a crash and I bothered to fix it.
> The test is generated by a fuzzer so I'm not entirely sure how likely is to hit a situation like this in the wild, but still I thought it was worth fixing. I'm working with Daniel on NewGVN and I'd rather focus my efforts on that rather than fixing the load coercion system of some code I hope will go away in the foreseeable future. 
Hi Philip, in the light of what I said (i.e. that I'm not entirely sure it's worth working on fixing this problem) are you OK with me updating the patch (i.e. adding the check) and going forward? 
If so, I can spend some more time on this patch. Otherwise I'll abandon to clean up my queue.


More information about the llvm-commits mailing list