[PATCH] D26098: [SelectionDAG] Fix a crash visiting `AND` nodes

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 14:50:13 PDT 2016

hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added inline comments.
This revision is now accepted and ready to land.

Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3053
+        // Bail out, this node will probably disappear anyway.
+        if (ShiftBits == 0)
+          return SDValue();
To micro-optimize, I'd move this to before we count bits in the AndMask and get the integer VT. Otherwise, LGTM.


More information about the llvm-commits mailing list