[PATCH] D26098: [SelectionDAG] Fix a crash visiting `AND` nodes

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 14:17:07 PDT 2016


davide added a comment.

In https://reviews.llvm.org/D26098#582458, @escha wrote:

> Might it be better to just bail if ShiftBits is zero? This seems like a classic case of "trying to optimize a node that itself is going to disappear when it gets combine()'d", so maybe we should just not do this "optimization" if the shift is no shift at all.


Sounds reasonable.


https://reviews.llvm.org/D26098





More information about the llvm-commits mailing list