[PATCH] D25963: [LoopUnroll] Implement profile-based loop peeling

David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 13:36:44 PDT 2016


davidxl added inline comments.


================
Comment at: lib/Transforms/Utils/LoopUnrollPeel.cpp:63
+unsigned llvm::getPeelCount(Loop *L, unsigned LoopSize,
+                            TargetTransformInfo::UnrollingPreferences *UP) {
+  if (!canPeel(L))
----------------
mkuper wrote:
> davidxl wrote:
> > Is UP parameter intended to be used?
> Sorry, I don't quite understand what you mean here. It is used (in line 84 or below). Could you explain?
Sorry I misread the early return as the regular return. Anyway, if UP is used here, there seems redundant to set UP.PeelCount in the caller of this function.


https://reviews.llvm.org/D25963





More information about the llvm-commits mailing list