[PATCH] D26095: Implement vector shift builtins - llvm portion.

Nemanja Ivanovic via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 13:18:45 PDT 2016

nemanjai added a comment.

Other than the minor nit, this LGTM.

Comment at: lib/Target/PowerPC/PPCInstrAltivec.td:1339
+def VSLV : VX1_VT5_VA5_VB5<1860, "vslv",
+    [ (set v16i8 : $vD, (int_ppc_altivec_vslv v16i8 : $vA, v16i8 : $vB)) ]>;
+def VSRV : VX1_VT5_VA5_VB5<1796, "vsrv",
Please fix the spacing. The square bracket needs to line up to just inside the angled bracket (i.e. `[` lines up with `1`).
Also remove the spaces that make the pattern look out of place with respect to others. It should be:
`[(set v16i8:$vD, (int_ppc_altivec_vslv v16i8:$vA, v16i8:$vB))]`
Same below.


More information about the llvm-commits mailing list