[PATCH] D26042: Consolidate BumpPtrAllocators.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 12:53:27 PDT 2016


On 28 October 2016 at 13:40, Mehdi AMINI <mehdi.amini at apple.com> wrote:
> mehdi_amini added inline comments.
>
>
> ================
> Comment at: ELF/Memory.h:31
> +extern llvm::BumpPtrAllocator BAlloc;
> +extern llvm::StringSaver Saver;
> +
> ----------------
> Global mutable state never seems like a good idea.

I disagree. This is program code and a global mutable state seems the
most obviously correct way to make sure we have a complete list of all
the allocators.

Cheers,
Rafael


More information about the llvm-commits mailing list