[PATCH] D26040: [CodeView] Add CodeViewRecordIO for reading and writing, and use it for reading type records.

Bob Haarman via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 11:49:20 PDT 2016

inglorion added a comment.

I like how this gives us basically a single definition of how to map between objects and byte streams that we can then use for reading and writing. I am a bit unhappy with the repeated if (IsWriting) ... in CodeViewRecordIO. How would you feel about making two different classes - one to implement the reading and one to implement the writing?


More information about the llvm-commits mailing list