[PATCH] D26064: [ADT] IntervalMap: fix setStart and setStop

Michael LeMay via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 11:15:48 PDT 2016


mlemay-intel added a comment.

In https://reviews.llvm.org/D26064#582202, @vsk wrote:

> In https://reviews.llvm.org/D26064#582164, @mlemay-intel wrote:
>
> > In https://reviews.llvm.org/D26064#581794, @vsk wrote:
> >
> > > ...
> > >
> > > - If we create a 0-element interval using setStart/setStop, it just gets deleted.
> >
> >
> > The revised assertion will fail in that case.  Is deleting the interval actually the desired behavior?
>
>
> Looking at it more, it shouldn't be possible to do what I described (creating a 0-element interval using setStart/setStop). I'm walking the request for that test back :).


Sounds good, thanks. :)


https://reviews.llvm.org/D26064





More information about the llvm-commits mailing list