[PATCH] D26070: [ELF] Fix fetching source line, when file has multiple "AX" sections

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 07:32:49 PDT 2016


yes, adding a getSectionOffset seems the best way.

Cheers,
Rafael


On 28 October 2016 at 10:20, Eugene Leviant <evgeny.leviant at gmail.com> wrote:
> evgeny777 added inline comments.
>
>
> ================
> Comment at: ELF/InputFiles.cpp:50
> +
> +  DenseMap<StringRef, uint64_t> OffsetMap;
> +};
> ----------------
> rafael wrote:
>> Section names don't need to be unique. You need to used the section index.
>>
>> For an easy example use -fno-unique-section-names.
> Unfortunately SectionRef doesn't allow getting it. Probably makes sense to propose patch to ELFObjectFile.h first and get Offset directly from SectionRef
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D26070
>
>
>


More information about the llvm-commits mailing list