[PATCH] D26042: Consolidate BumpPtrAllocators.

[Rafael Ávila de Espíndola via llvm-commits]

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with nits. We can also do this as is first and then try to free up some memory earlier.

This has small performance fluctuations, no regression or improvement over 1%.



================
Comment at: ELF/Driver.h:65
-private:
-  llvm::BumpPtrAllocator Alloc;
 };
----------------
This one might make sense to remain. We can free it after option parsing, no?


================
Comment at: ELF/DriverUtils.cpp:81
   // Expand response files. '@<filename>' is replaced by the file's contents.
-  StringSaver Saver(Alloc);
   cl::ExpandResponseFiles(Saver, getQuotingStyle(Args), Vec);
----------------
This too can be freed earlier.


https://reviews.llvm.org/D26042