[PATCH] D25516: [Object/ELF] - Check index argument in getSymbol().

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 22:48:07 PDT 2016


>On second thought, we should never use report_fatal_error in libObject to report corrupted input, because it enforces a specific error handling policy rather than >defer it to an application. Could you return an error instead?

Previously we would just crash, so report_fatal_error helps here, but I agree that ideally we might want to have API that
is able to dump files even if they are corrupted.
I`ll prepare a patch.

George.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161028/eb32d505/attachment.html>


More information about the llvm-commits mailing list