[PATCH] D26016: BitcodeReader: Require clients to read the block info block at most once.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 13:37:13 PDT 2016


pcc added a comment.

> Right now we have a completely concatenative format

At least in LLVM modules this isn't the case because VSTOFFSET is relative to the start of the file.

Anyway, I expect that there is more value in allowing bitcode clients to use multiple block info blocks like this than in allowing external programs to concatenate. The latter would seem to complicate the implementation of reader clients because you would now potentially have multiple conflicting interpretations of abbreviations.


https://reviews.llvm.org/D26016





More information about the llvm-commits mailing list