[PATCH] D25879: [coroutines] Add allocation and deallocation substatements.

Gor Nishanov via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 06:47:52 PDT 2016

GorNishanov marked 2 inline comments as done.
GorNishanov added inline comments.

Comment at: lib/CodeGen/CGCoroutine.cpp:71-72
+  if (!createCoroData(*this, CurCoro, CoroId, nullptr)) {
+    // User inserted __builtin_coro_id by hand. Should not try to emit anything.
+    return;
+  }
rsmith wrote:
> Can this really happen? The `CoroutineBodyStmt` should be the first thing we emitted into a new function, so it seems like we shouldn't have pre-existing coro data yet.
Yep. You are right! I took it out and made createCoroData return void, since nobody cares about its result anymore.


More information about the llvm-commits mailing list