[PATCH] D26013: Change DWARF parser to use enumerations for DWARF tags, attributes and forms.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 26 21:55:47 PDT 2016

dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.

Comment at: lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp:49
+    } else if (A == 0 && F == 0) {
+      // Successfully parsed this abbreviation
+      break;
Maybe "Finished" rather than "Successfully" (or "Successfully finished") - or perhaps "Reached the end-of-abbreviation marker" or something.

Comment at: lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp:52
+    } else {
+      // Either the attribute or form was zero, but not both which is an error
Maybe there's a better way to phrase this comment (I get what you're trying to say, but it parses a bit oddly for my brain at least - "both which is an error" almost sounds like it's referring to the previous case, which isn't an error but the end-of-input marker).


More information about the llvm-commits mailing list