[PATCH] D25927: [cfi] Implement cfi-icall using inline assembly.
Evgeniy Stepanov via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 26 14:23:15 PDT 2016
eugenis marked an inline comment as done.
eugenis added inline comments.
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:669
+ if (!Dest->hasLocalLinkage())
+ OS << ".globl " << Dest->getName() << "\n";
+ OS << ".type " << Dest->getName() << ", function\n";
> I wonder whether we want to escape these names? This appears to be the escaping we'd need to use:
> Maybe it's not necessary though since we pretty much expect all names we see to satisfy `MCAsmInfo::isValidUnquotedName`.
Looks like we should escape the names.
It's easy to call a function "\n" with __asm__ in the declaration, and that breaks the jumptable code.
More information about the llvm-commits