[PATCH] D25929: Add llvm-echo command.

[David Majnemer via llvm-commits]

majnemer added inline comments.


================
Comment at: utils/llvm-echo/llvm-echo.cpp:28-35
+#if LLVM_ON_WIN32
+  const char *Cmdline = GetCommandLineA();
+  BumpPtrAllocator Alloc;
+  StringSaver Saver(Alloc);
+  llvm::cl::TokenizeGNUCommandLine(Cmdline, Saver, Args);
+#else
+  Args.insert(Args.begin(), Argv, Argv + Argc);
----------------
This should probably be a call to `Process::GetArgumentVector`, it abstracts away this difference.


https://reviews.llvm.org/D25929