[PATCH] D25812: X86: Introduce the "relocImm" ComplexPattern, which represents a relocatable immediate.

Chris Lattner via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 22:08:50 PDT 2016

lattner added a comment.

This seems like a huge improvement over the status quo.  Unfortunately, it's been a couple of years since I've worked on this area though, so I'd like you to get someone working on the X86 backend to look at it.

For example, the change to CodeGenDAGPatterns.cpp is probably necessary given the current tblgen support, but it is better to solve the fix and introduce a pattern cost field to ComplexPattern.  I'd have it default to -1 (in which case tblgen would use the default "numoperands*3" heuristic), but allow this to be overridden by def's like relocImm that want to specify a specific complexity to use.


More information about the llvm-commits mailing list