[PATCH] D25970: DCE math library calls with a constant operand

David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 15:27:28 PDT 2016


davidxl added inline comments.


================
Comment at: lib/Analysis/ConstantFolding.cpp:1971
+
+bool llvm::isMathLibCallNoop(CallSite CS, const TargetLibraryInfo *TLI) {
+  Function *F = CS.getCalledFunction();
----------------
There are lots of duplicated logic here with LibcallShinkWrap pass. I think the right way to do is let the later passes to clean up the dead calls. This can be done by pushing libcall shrinkwrap later in the pipeline.


Repository:
  rL LLVM

https://reviews.llvm.org/D25970





More information about the llvm-commits mailing list